V4L/DVB: ivtv: sizeof() => ARRAY_SIZE()
authorDan Carpenter <error27@gmail.com>
Wed, 17 Mar 2010 15:11:56 +0000 (12:11 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 18 May 2010 03:50:26 +0000 (00:50 -0300)
This fixes a smatch warning:
drivers/media/video/ivtv/ivtv-vbi.c +138 ivtv_write_vbi(43)
error: buffer overflow 'vi->cc_payload' 256 <= 1023

Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Andy Walls <awalls@radix.net>
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/ivtv/ivtv-vbi.c

index f420d31b937dcfccfb8ee64c76eade9197d62979..d73af45dede684e16f1b0788657b1ddf1140f116 100644 (file)
@@ -134,7 +134,7 @@ void ivtv_write_vbi(struct ivtv *itv, const struct v4l2_sliced_vbi_data *sliced,
                        }
                }
        }
-       if (found_cc && vi->cc_payload_idx < sizeof(vi->cc_payload)) {
+       if (found_cc && vi->cc_payload_idx < ARRAY_SIZE(vi->cc_payload)) {
                vi->cc_payload[vi->cc_payload_idx++] = cc;
                set_bit(IVTV_F_I_UPDATE_CC, &itv->i_flags);
        }