tmio_mmc: correct probe return value for num_resources != 3
authorPhilipp Zabel <philipp.zabel@gmail.com>
Thu, 4 Jun 2009 18:12:34 +0000 (20:12 +0200)
committerPierre Ossman <pierre@ossman.eu>
Sat, 13 Jun 2009 20:43:00 +0000 (22:43 +0200)
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Acked-by: Ian Molton <ian@mnementh.co.uk>
Signed-off-by: Pierre Ossman <pierre@ossman.eu>
drivers/mmc/host/tmio_mmc.c

index bbcbd72a46a4e8c8f78a7aee0676b9137e337add..b576640704856b4ae3e33c2450112284d685432d 100644 (file)
@@ -522,23 +522,21 @@ static int __devinit tmio_mmc_probe(struct platform_device *dev)
        struct resource *res_ctl, *res_cnf;
        struct tmio_mmc_host *host;
        struct mmc_host *mmc;
-       int ret = -ENOMEM;
+       int ret = -EINVAL;
 
        if (dev->num_resources != 3)
                goto out;
 
        res_ctl = platform_get_resource(dev, IORESOURCE_MEM, 0);
        res_cnf = platform_get_resource(dev, IORESOURCE_MEM, 1);
-       if (!res_ctl || !res_cnf) {
-               ret = -EINVAL;
+       if (!res_ctl || !res_cnf)
                goto out;
-       }
 
        pdata = cell->driver_data;
-       if (!pdata || !pdata->hclk) {
-               ret = -EINVAL;
+       if (!pdata || !pdata->hclk)
                goto out;
-       }
+
+       ret = -ENOMEM;
 
        mmc = mmc_alloc_host(sizeof(struct tmio_mmc_host), &dev->dev);
        if (!mmc)