usb: gadget: FunctionFS: Return -ENOENT instead of -ENODEV when device not found.

Syscall mount returns -ENODEV error if requested FS type
has not been found. Returning the same error from FFS mount
callback makes value returned to userspace misleading.

Other file systems returns -ENOENT if requested device
has not been found. Adjust FFS to this convention to make
error codes meaningfull.

Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
index 74202d67f91166b0d0ef0fc49ab387602260ad12..88d6fa2290fd6d35a5c3b99828b85fb6b7fd4514 100644 (file)
--- a/drivers/usb/gadget/f_fs.c
+++ b/drivers/usb/gadget/f_fs.c
@@ -2899,12 +2899,12 @@ static void *ffs_acquire_dev(const char *dev_name)
 
        ffs_dev = _ffs_find_dev(dev_name);
        if (!ffs_dev)
-               ffs_dev = ERR_PTR(-ENODEV);
+               ffs_dev = ERR_PTR(-ENOENT);
        else if (ffs_dev->mounted)
                ffs_dev = ERR_PTR(-EBUSY);
        else if (ffs_dev->ffs_acquire_dev_callback &&
            ffs_dev->ffs_acquire_dev_callback(ffs_dev))
-               ffs_dev = ERR_PTR(-ENODEV);
+               ffs_dev = ERR_PTR(-ENOENT);
        else
                ffs_dev->mounted = true;
 

diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
index fe12e6a2744896a08f9cb55039c45824756f9f52..06acfa55864a639a6015689770b4ccb06f01ad40 100644 (file)
--- a/drivers/usb/gadget/g_ffs.c
+++ b/drivers/usb/gadget/g_ffs.c
@@ -276,7 +276,7 @@ module_exit(gfs_exit);
 static void *functionfs_acquire_dev(struct ffs_dev *dev)
 {
        if (!try_module_get(THIS_MODULE))
-               return ERR_PTR(-ENODEV);
+               return ERR_PTR(-ENOENT);
        
        return 0;
 }