lcs: ODEBUG: object is on stack, but not annotated.
authorKlaus-Dieter Wacker <kdwacker@de.ibm.com>
Wed, 14 Oct 2009 22:54:57 +0000 (22:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Oct 2009 06:57:21 +0000 (23:57 -0700)
Timer_list structure in lcs_send_lancmd() is allocated on stack.
Initialization with init_timer() leads to above ODEBUG message.
Instead use init_timer_on_stack() which prevents above msg.

Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/lcs.c

index a70de9b4bf2929938fd5f081673f19a8e0d61d42..f8dfd70a89d90f256b512e4087d8a3e9bdad579a 100644 (file)
@@ -889,7 +889,7 @@ lcs_send_lancmd(struct lcs_card *card, struct lcs_buffer *buffer,
        rc = lcs_ready_buffer(&card->write, buffer);
        if (rc)
                return rc;
-       init_timer(&timer);
+       init_timer_on_stack(&timer);
        timer.function = lcs_lancmd_timeout;
        timer.data = (unsigned long) reply;
        timer.expires = jiffies + HZ*card->lancmd_timeout;