crypto: nx - use of_property_read_u32()
authorsaurabh <saurabh.truth@gmail.com>
Mon, 23 Nov 2015 09:56:54 +0000 (15:26 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 24 Nov 2015 10:19:21 +0000 (18:19 +0800)
use of_propert_read_u32() for reading int value,
it can help reducing number of variables used

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Acked-by: Dan Streetman <ddstreet@ieee.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/nx/nx-842-powernv.c

index 9ef51fafdbffaef11b800619818e10ae5f52cc17..87f7a0f1a3ecc03ae7df87773bd71dc3a222c4b2 100644 (file)
@@ -525,7 +525,6 @@ static int nx842_powernv_decompress(const unsigned char *in, unsigned int inlen,
 static int __init nx842_powernv_probe(struct device_node *dn)
 {
        struct nx842_coproc *coproc;
-       struct property *ct_prop, *ci_prop;
        unsigned int ct, ci;
        int chip_id;
 
@@ -534,18 +533,16 @@ static int __init nx842_powernv_probe(struct device_node *dn)
                pr_err("ibm,chip-id missing\n");
                return -EINVAL;
        }
-       ct_prop = of_find_property(dn, "ibm,842-coprocessor-type", NULL);
-       if (!ct_prop) {
+
+       if (of_property_read_u32(dn, "ibm,842-coprocessor-type", &ct)) {
                pr_err("ibm,842-coprocessor-type missing\n");
                return -EINVAL;
        }
-       ct = be32_to_cpu(*(unsigned int *)ct_prop->value);
-       ci_prop = of_find_property(dn, "ibm,842-coprocessor-instance", NULL);
-       if (!ci_prop) {
+
+       if (of_property_read_u32(dn, "ibm,842-coprocessor-instance", &ci)) {
                pr_err("ibm,842-coprocessor-instance missing\n");
                return -EINVAL;
        }
-       ci = be32_to_cpu(*(unsigned int *)ci_prop->value);
 
        coproc = kmalloc(sizeof(*coproc), GFP_KERNEL);
        if (!coproc)