drm/kms: allow drm_mode_group with no objects
authorBen Skeggs <bskeggs@redhat.com>
Mon, 4 Jul 2011 03:16:17 +0000 (03:16 +0000)
committerDave Airlie <airlied@redhat.com>
Thu, 7 Jul 2011 07:49:00 +0000 (17:49 +1000)
Sometimes we could be controlling a device (such as an NVIDIA Tesla) that
has no crtcs/encoders/connectors.

One could argue that the driver should unset DRIVER_MODESET in this case,
but that changes a whole heap of the DRM's other behaviours, and it's much
easier to just be a modesetting driver without any outputs.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_crtc.c

index 21058e6ad2b80ccbc10be90795402701270d1585..82db1850666253dc021f8a43e635fe91ebce94df 100644 (file)
@@ -886,9 +886,6 @@ int drm_mode_group_init(struct drm_device *dev, struct drm_mode_group *group)
        total_objects += dev->mode_config.num_connector;
        total_objects += dev->mode_config.num_encoder;
 
-       if (total_objects == 0)
-               return -EINVAL;
-
        group->id_list = kzalloc(total_objects * sizeof(uint32_t), GFP_KERNEL);
        if (!group->id_list)
                return -ENOMEM;