power: max8903_charger: set IRQF_ONESHOT if no primary handler is specified
authorSaurabh Sengar <saurabh.truth@gmail.com>
Thu, 19 Nov 2015 07:12:59 +0000 (12:42 +0530)
committerSebastian Reichel <sre@kernel.org>
Sat, 5 Dec 2015 01:06:50 +0000 (02:06 +0100)
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled.

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/max8903_charger.c

index 6d39d52040d4ab982f01066c47239ff295323427..17876caf31e5d7e8cba3405c7a037e436e52ec75 100644 (file)
@@ -291,10 +291,10 @@ static int max8903_probe(struct platform_device *pdev)
 
        if (pdata->dc_valid) {
                ret = devm_request_threaded_irq(dev, gpio_to_irq(pdata->dok),
-                                               NULL, max8903_dcin,
-                                               IRQF_TRIGGER_FALLING |
-                                               IRQF_TRIGGER_RISING,
-                                               "MAX8903 DC IN", data);
+                                       NULL, max8903_dcin,
+                                       IRQF_TRIGGER_FALLING |
+                                       IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                       "MAX8903 DC IN", data);
                if (ret) {
                        dev_err(dev, "Cannot request irq %d for DC (%d)\n",
                                        gpio_to_irq(pdata->dok), ret);
@@ -304,10 +304,10 @@ static int max8903_probe(struct platform_device *pdev)
 
        if (pdata->usb_valid) {
                ret = devm_request_threaded_irq(dev, gpio_to_irq(pdata->uok),
-                                               NULL, max8903_usbin,
-                                               IRQF_TRIGGER_FALLING |
-                                               IRQF_TRIGGER_RISING,
-                                               "MAX8903 USB IN", data);
+                                       NULL, max8903_usbin,
+                                       IRQF_TRIGGER_FALLING |
+                                       IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                       "MAX8903 USB IN", data);
                if (ret) {
                        dev_err(dev, "Cannot request irq %d for USB (%d)\n",
                                        gpio_to_irq(pdata->uok), ret);
@@ -317,10 +317,10 @@ static int max8903_probe(struct platform_device *pdev)
 
        if (pdata->flt) {
                ret = devm_request_threaded_irq(dev, gpio_to_irq(pdata->flt),
-                                               NULL, max8903_fault,
-                                               IRQF_TRIGGER_FALLING |
-                                               IRQF_TRIGGER_RISING,
-                                               "MAX8903 Fault", data);
+                                       NULL, max8903_fault,
+                                       IRQF_TRIGGER_FALLING |
+                                       IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                       "MAX8903 Fault", data);
                if (ret) {
                        dev_err(dev, "Cannot request irq %d for Fault (%d)\n",
                                        gpio_to_irq(pdata->flt), ret);