USB: wusb: Use kcalloc instead of kzalloc to allocate array
authorThomas Meyer <thomas@m3y3r.de>
Tue, 29 Nov 2011 21:08:00 +0000 (22:08 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 10 Dec 2011 00:18:20 +0000 (16:18 -0800)
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/wusbcore/security.c

index 371f61733f0538e9cda6d0be0d919727fc28e08a..fa810a83e8300957c72de584ab3f3fcd1e31a29a 100644 (file)
@@ -354,7 +354,7 @@ int wusb_dev_4way_handshake(struct wusbhc *wusbhc, struct wusb_dev *wusb_dev,
        struct wusb_keydvt_in keydvt_in;
        struct wusb_keydvt_out keydvt_out;
 
-       hs = kzalloc(3*sizeof(hs[0]), GFP_KERNEL);
+       hs = kcalloc(3, sizeof(hs[0]), GFP_KERNEL);
        if (hs == NULL) {
                dev_err(dev, "can't allocate handshake data\n");
                goto error_kzalloc;