ASoC: fsl: remove unnecessary call to dma_unmap_single
authorTimur Tabi <timur@freescale.com>
Fri, 14 Sep 2012 21:14:36 +0000 (16:14 -0500)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 19 Sep 2012 02:32:44 +0000 (22:32 -0400)
Remove a call to dma_unmap_single() from the PowerPC ASoC DMA driver.  The
buffer is allocated and not actually mapped, so the unmap call doesn't
make sense.  It was probably left over from some early version of the driver.

This bug was unnoticed for so long because the DMA mapping functions normally
don't do anything on PowerPC.

Signed-off-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/fsl/fsl_dma.c

index 96bb92dd174c0ae14c0b262ae4f55fd6df2d3f70..6feb26500580749fc4b19b18368fdcd2d73175d0 100644 (file)
@@ -823,12 +823,6 @@ static int fsl_dma_close(struct snd_pcm_substream *substream)
                if (dma_private->irq)
                        free_irq(dma_private->irq, dma_private);
 
-               if (dma_private->ld_buf_phys) {
-                       dma_unmap_single(dev, dma_private->ld_buf_phys,
-                                        sizeof(dma_private->link),
-                                        DMA_TO_DEVICE);
-               }
-
                /* Deallocate the fsl_dma_private structure */
                dma_free_coherent(dev, sizeof(struct fsl_dma_private),
                                  dma_private, dma_private->ld_buf_phys);