fat: fix bug in enforcing Long File Name length
authorNamjae Jeon <linkinjeon@gmail.com>
Fri, 23 Mar 2012 22:02:39 +0000 (15:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 23 Mar 2012 23:58:40 +0000 (16:58 -0700)
Since '*outlen' is initialized to zero, it is currently possible to
create a filename of length (FAT_LFN_LEN + 1) when utf8 is not enabled.
To enforce the FAT_LFN_LEN limit, we must perform one less iteration.

Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Ravishankar N <cyberax82@gmail.com>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fat/namei_vfat.c

index aae3b4e1057de5e3655d9c6a5483804130f044d7..98ae804f5273df49ba857f8853d83ba7503c4255 100644 (file)
@@ -522,7 +522,7 @@ xlate_to_uni(const unsigned char *name, int len, unsigned char *outname,
                op = &outname[*outlen * sizeof(wchar_t)];
        } else {
                for (i = 0, ip = name, op = outname, *outlen = 0;
-                        i < len && *outlen <= FAT_LFN_LEN;
+                        i < len && *outlen < FAT_LFN_LEN;
                         *outlen += 1) {
                        if (escape && (*ip == ':')) {
                                if (i > len - 5)