projects
/
GitHub
/
moto-9609
/
android_kernel_motorola_exynos9610.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c3b46c7
)
firmware: qemu_fw_cfg.c: potential unintialized variable
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 14 Apr 2016 09:33:37 +0000
(12:33 +0300)
committer
Michael S. Tsirkin
<mst@redhat.com>
Thu, 21 Apr 2016 13:12:36 +0000
(16:12 +0300)
It acpi_acquire_global_lock() return AE_NOT_CONFIGURED then "glk" isn't
initialized, which, if you got very unlucky, could cause a bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/firmware/qemu_fw_cfg.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/firmware/qemu_fw_cfg.c
b/drivers/firmware/qemu_fw_cfg.c
index 815c4a5cae543e228a634eae28241bc6f24ac1ed..1b95475b6aefefd5144bca29ab464304826c6377 100644
(file)
--- a/
drivers/firmware/qemu_fw_cfg.c
+++ b/
drivers/firmware/qemu_fw_cfg.c
@@
-77,7
+77,7
@@
static inline u16 fw_cfg_sel_endianness(u16 key)
static inline void fw_cfg_read_blob(u16 key,
void *buf, loff_t pos, size_t count)
{
- u32 glk;
+ u32 glk
= -1U
;
acpi_status status;
/* If we have ACPI, ensure mutual exclusion against any potential