[media] hdpvr: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:10 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 20:46:08 +0000 (18:46 -0200)
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/hdpvr/hdpvr-i2c.c

index 031cf024304c356e8573f13119505de49b71e1a8..6c5054f3f6745cd10c4bc35eb873352898957b8d 100644 (file)
@@ -217,8 +217,7 @@ int hdpvr_register_i2c_adapter(struct hdpvr_device *dev)
 
        hdpvr_activate_ir(dev);
 
-       memcpy(&dev->i2c_adapter, &hdpvr_i2c_adapter_template,
-              sizeof(struct i2c_adapter));
+       dev->i2c_adapter = hdpvr_i2c_adapter_template;
        dev->i2c_adapter.dev.parent = &dev->udev->dev;
 
        i2c_set_adapdata(&dev->i2c_adapter, dev);