ASoC: Fix soc-cache buffer overflow bug
authorDimitris Papastamos <dp@opensource.wolfsonmicro.com>
Tue, 21 Sep 2010 14:03:26 +0000 (15:03 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Wed, 22 Sep 2010 11:01:05 +0000 (12:01 +0100)
Make sure we stay within the cache boundaries when updating the
register cache.

Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/soc-cache.c

index adbc68ce90508221cc919121fc19e062fd309f44..15d2779074ef72c9b509bfa13511289c09159aae 100644 (file)
@@ -203,8 +203,9 @@ static int snd_soc_8_16_write(struct snd_soc_codec *codec, unsigned int reg,
        data[1] = (value >> 8) & 0xff;
        data[2] = value & 0xff;
 
-       if (!snd_soc_codec_volatile_register(codec, reg))
-               reg_cache[reg] = value;
+       if (!snd_soc_codec_volatile_register(codec, reg)
+               && reg < codec->driver->reg_cache_size)
+                       reg_cache[reg] = value;
 
        if (codec->cache_only) {
                codec->cache_sync = 1;