scsi: lpfc: Fix system panic when express lane enabled.
authorJames Smart <jsmart2021@gmail.com>
Fri, 16 Jun 2017 05:56:41 +0000 (22:56 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 20 Jun 2017 01:39:01 +0000 (21:39 -0400)
There is a null pointer dereference that can happen in the FOF interrupt
handler.

The driver was not setting up cq->assoc_qp_for sli4_hba->oas_cq.

Initialize cq->assoc_qp before accessing it.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_sli.c

index 040575adf9c6efa41c90845451933687ac302a9b..4f2cc395597e299d6c26727fd72d91f6be0dd099 100644 (file)
@@ -13560,6 +13560,9 @@ lpfc_sli4_fof_handle_eqe(struct lpfc_hba *phba, struct lpfc_eqe *eqe)
                return;
        }
 
+       /* Save EQ associated with this CQ */
+       cq->assoc_qp = phba->sli4_hba.fof_eq;
+
        /* Process all the entries to the OAS CQ */
        while ((cqe = lpfc_sli4_cq_get(cq))) {
                workposted |= lpfc_sli4_fp_handle_cqe(phba, cq, cqe);