PCI: dra7xx: Remove unneeded use of IS_ERR_VALUE()
authorFabio Estevam <fabio.estevam@freescale.com>
Thu, 20 Aug 2015 06:30:36 +0000 (01:30 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 20 Aug 2015 06:30:36 +0000 (01:30 -0500)
There is no need to use the IS_ERR_VALUE() macro for checking the return
value from pm_runtime_* functions.

Test for a negative pm_runtime_get_sync() return value instead of using
IS_ERR_VALUE().

The semantic patch that makes this change is available in
scripts/coccinelle/api/pm_runtime.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Kishon Vijay Abraham I <kishon@ti.com>
drivers/pci/host/pci-dra7xx.c

index abb85a157ce0e76483503893b4081f0f1ac63711..190989908a1aba4f51255d3708546caf3df9cffc 100644 (file)
@@ -397,7 +397,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
 
        pm_runtime_enable(dev);
        ret = pm_runtime_get_sync(dev);
-       if (IS_ERR_VALUE(ret)) {
+       if (ret < 0) {
                dev_err(dev, "pm_runtime_get_sync failed\n");
                goto err_get_sync;
        }