drbd: abort drbd_start_resync if there is no connection

This was found by a static analysis tool. While highly unlikely, be sure
to return without dereferencing the NULL pointer.

Reported-by: Shaobo <shaobo@cs.utah.edu>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index f0717a97a42a62c759101c9d562bee7bf0fa6ad1..03471b3fce86c7660617f7871bf63c78a3f6c585 100644 (file)
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -1756,6 +1756,11 @@ void drbd_start_resync(struct drbd_device *device, enum drbd_conns side)
                return;
        }
 
+       if (!connection) {
+               drbd_err(device, "No connection to peer, aborting!\n");
+               return;
+       }
+
        if (!test_bit(B_RS_H_DONE, &device->flags)) {
                if (side == C_SYNC_TARGET) {
                        /* Since application IO was locked out during C_WF_BITMAP_T and