NFC: Removed addressed shdlc TODOs
authorEric Lapuyade <eric.lapuyade@intel.com>
Thu, 3 May 2012 12:53:20 +0000 (14:53 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 9 Jul 2012 20:42:05 +0000 (16:42 -0400)
The questions asked in the comments have been answered and addressed.

Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/hci/shdlc.c

index d7c74d152a72a3ed56a22d1c7692b1fc6600edbb..18d1536df5f68b6a9cc57edfa2d84c958d960ae3 100644 (file)
@@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r)
                shdlc->state = SHDLC_CONNECTED;
        } else {
                shdlc->state = SHDLC_DISCONNECTED;
-
-               /*
-                * TODO: Could it be possible that there are pending
-                * executing commands that are waiting for connect to complete
-                * before they can be carried? As connect is a blocking
-                * operation, it would require that the userspace process can
-                * send commands on the same device from a second thread before
-                * the device is up. I don't think that is possible, is it?
-                */
        }
 
        shdlc->connect_result = r;
@@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc)
 {
        pr_debug("\n");
 
-       /* TODO: Check that this cannot be called while still in use */
-
        nfc_hci_unregister_device(shdlc->hdev);
        nfc_hci_free_device(shdlc->hdev);