drm/bochs: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 15 Jul 2016 12:23:15 +0000 (14:23 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jul 2016 06:54:55 +0000 (08:54 +0200)
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1e3a8c0d-e737-f092-727e-af7e3810b8dc@users.sourceforge.net
drivers/gpu/drm/bochs/bochs_mm.c

index 6cf912c45e481c1d6a323d40bea32bc0073c275c..28a60a7dc2f81c14c022bc78e41a54d9519f590b 100644 (file)
@@ -474,8 +474,8 @@ int bochs_dumb_mmap_offset(struct drm_file *file, struct drm_device *dev,
 static void bochs_user_framebuffer_destroy(struct drm_framebuffer *fb)
 {
        struct bochs_framebuffer *bochs_fb = to_bochs_framebuffer(fb);
-       if (bochs_fb->obj)
-               drm_gem_object_unreference_unlocked(bochs_fb->obj);
+
+       drm_gem_object_unreference_unlocked(bochs_fb->obj);
        drm_framebuffer_cleanup(fb);
        kfree(fb);
 }