add missing setattr methods

For the new truncate sequence every filesystem that wants to truncate on-disk
state needs a seattr method.  Convert the remaining filesystems that implement
the truncate inode operation to have its own setattr method.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
index 88bf1b562641383e514e41ffa8941b327f913abb..d6ebe53fbdbf63eb2430abf032fbe8d4d3eb4b6c 100644 (file)
--- a/fs/hfsplus/inode.c
+++ b/fs/hfsplus/inode.c
@@ -290,9 +290,21 @@ static int hfsplus_file_release(struct inode *inode, struct file *file)
        return 0;
 }
 
+static int hfsplus_setattr(struct dentry *dentry, struct iattr *attr)
+{
+       struct inode *inode = dentry->d_inode;
+       int error;
+
+       error = inode_change_ok(inode, attr);
+       if (error)
+               return error;
+       return inode_setattr(inode, attr);
+}
+
 static const struct inode_operations hfsplus_file_inode_operations = {
        .lookup         = hfsplus_file_lookup,
        .truncate       = hfsplus_file_truncate,
+       .setattr        = hfsplus_setattr,
        .setxattr       = hfsplus_setxattr,
        .getxattr       = hfsplus_getxattr,
        .listxattr      = hfsplus_listxattr,

diff --git a/fs/minix/file.c b/fs/minix/file.c
index d5320ff23faf28c38678cd12dfb25f1db24ca4d4..7a45dd1fe2e54b3fc1ae78be29954c2faae4e334 100644 (file)
--- a/fs/minix/file.c
+++ b/fs/minix/file.c
@@ -23,7 +23,19 @@ const struct file_operations minix_file_operations = {
        .splice_read    = generic_file_splice_read,
 };
 
+static int minix_setattr(struct dentry *dentry, struct iattr *attr)
+{
+       struct inode *inode = dentry->d_inode;
+       int error;
+
+       error = inode_change_ok(inode, attr);
+       if (error)
+               return error;
+       return inode_setattr(inode, attr);
+}
+
 const struct inode_operations minix_file_inode_operations = {
        .truncate       = minix_truncate,
+       .setattr        = minix_setattr,
        .getattr        = minix_getattr,
 };

diff --git a/fs/omfs/file.c b/fs/omfs/file.c
index 810cff346468a96e446a1fbc0d5a2c4b14d01ad4..78c9f0c1a2f3d6c9e2b01fe3839f3f40d12b0b09 100644 (file)
--- a/fs/omfs/file.c
+++ b/fs/omfs/file.c
@@ -341,7 +341,19 @@ const struct file_operations omfs_file_operations = {
        .splice_read = generic_file_splice_read,
 };
 
+static int omfs_setattr(struct dentry *dentry, struct iattr *attr)
+{
+       struct inode *inode = dentry->d_inode;
+       int error;
+
+       error = inode_change_ok(inode, attr);
+       if (error)
+               return error;
+       return inode_setattr(inode, attr);
+}
+
 const struct inode_operations omfs_file_inops = {
+       .setattr = omfs_setattr,
        .truncate = omfs_truncate
 };
 

diff --git a/fs/sysv/file.c b/fs/sysv/file.c
index 750cc22349bd67b509da4985f631321a4962f6b3..94f6319292a10d71fc6ac14c3307226d83550e9f 100644 (file)
--- a/fs/sysv/file.c
+++ b/fs/sysv/file.c
@@ -30,7 +30,19 @@ const struct file_operations sysv_file_operations = {
        .splice_read    = generic_file_splice_read,
 };
 
+static int sysv_setattr(struct dentry *dentry, struct iattr *attr)
+{
+       struct inode *inode = dentry->d_inode;
+       int error;
+
+       error = inode_change_ok(inode, attr);
+       if (error)
+               return error;
+       return inode_setattr(inode, attr);
+}
+
 const struct inode_operations sysv_file_inode_operations = {
        .truncate       = sysv_truncate,
+       .setattr        = sysv_setattr,
        .getattr        = sysv_getattr,
 };

diff --git a/fs/udf/file.c b/fs/udf/file.c
index 94e06d6bddbd1fb973d7bd70b37664c485973529..7376032c89ce09e078b5e12bba36bf6e19591134 100644 (file)
--- a/fs/udf/file.c
+++ b/fs/udf/file.c
@@ -228,6 +228,18 @@ const struct file_operations udf_file_operations = {
        .llseek                 = generic_file_llseek,
 };
 
+static int udf_setattr(struct dentry *dentry, struct iattr *attr)
+{
+       struct inode *inode = dentry->d_inode;
+       int error;
+
+       error = inode_change_ok(inode, attr);
+       if (error)
+               return error;
+       return inode_setattr(inode, attr);
+}
+
 const struct inode_operations udf_file_inode_operations = {
+       .setattr                = udf_setattr,
        .truncate               = udf_truncate,
 };