drm/rockchip: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 15 Jul 2016 13:23:22 +0000 (15:23 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jul 2016 06:54:55 +0000 (08:54 +0200)
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/b66399ed-278b-b85d-4a21-b34164936ef6@users.sourceforge.net
drivers/gpu/drm/rockchip/rockchip_drm_fb.c

index 20f12bc5a386a1b9a43cea28a6a567731128d787..6f64e79b12ec671d25687ab17daa9212fadb7cbe 100644 (file)
@@ -43,14 +43,10 @@ struct drm_gem_object *rockchip_fb_get_gem_obj(struct drm_framebuffer *fb,
 static void rockchip_drm_fb_destroy(struct drm_framebuffer *fb)
 {
        struct rockchip_drm_fb *rockchip_fb = to_rockchip_fb(fb);
-       struct drm_gem_object *obj;
        int i;
 
-       for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++) {
-               obj = rockchip_fb->obj[i];
-               if (obj)
-                       drm_gem_object_unreference_unlocked(obj);
-       }
+       for (i = 0; i < ROCKCHIP_MAX_FB_BUFFER; i++)
+               drm_gem_object_unreference_unlocked(rockchip_fb->obj[i]);
 
        drm_framebuffer_cleanup(fb);
        kfree(rockchip_fb);