xen: netback: remove redundant xenvif_put
authorAndrew Jones <drjones@redhat.com>
Mon, 18 Feb 2013 10:29:20 +0000 (10:29 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Feb 2013 05:51:09 +0000 (00:51 -0500)
netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
a xenvif_put(). As callers of netbk_fatal_tx_err should only
have one reference to the vif at this time, then the xenvif_put
in netbk_fatal_tx_err is one too many.

Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/netback.c

index cd49ba9496361cccfceeaa4dbf8251cf3657e763..28543d6c8e405238b4e487f72a8d0699cbab856c 100644 (file)
@@ -893,7 +893,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
 {
        netdev_err(vif->dev, "fatal error; disabling device\n");
        xenvif_carrier_off(vif);
-       xenvif_put(vif);
 }
 
 static int netbk_count_requests(struct xenvif *vif,