smsc95xx: signedness bug in get_regs()

"retval" has to be a signed integer for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 05ecf14d6597721d00c3115630dce2682fd4a450..bd7cbaa688e421c7265195f1e251b55a5aa1b82d 100644 (file)
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -589,7 +589,8 @@ smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs,
                         void *buf)
 {
        struct usbnet *dev = netdev_priv(netdev);
-       unsigned int i, j, retval;
+       unsigned int i, j;
+       int retval;
        u32 *data = buf;
 
        retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);