fbdev: sh_mobile_hdmi: Don't set sh_hdmi::mode in the display on handler
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 29 Nov 2011 00:07:50 +0000 (01:07 +0100)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 12 Mar 2012 21:40:54 +0000 (22:40 +0100)
The struct sh_hdmi mode field is only used after being assigned by the
EDID read code. There is thus no need to initialize it from the LCDC
display var in the display on handler.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/video/sh_mobile_hdmi.c

index 2617609497182d07366971b9aff2bb3e363f7aba..37f935fd5a1087c7113af35a60a0adc1b9ade880 100644 (file)
@@ -995,7 +995,6 @@ static irqreturn_t sh_hdmi_hotplug(int irq, void *dev_id)
 static int sh_hdmi_display_on(struct sh_mobile_lcdc_entity *entity)
 {
        struct sh_hdmi *hdmi = entity_to_sh_hdmi(entity);
-       struct sh_mobile_lcdc_chan *ch = entity->lcdc;
 
        dev_dbg(hdmi->dev, "%s(%p): state %x\n", __func__, hdmi,
                hdmi->hp_state);
@@ -1006,15 +1005,10 @@ static int sh_hdmi_display_on(struct sh_mobile_lcdc_entity *entity)
         * HDMI_HOTPLUG_CONNECTED:      on monitor plug-in
         * HDMI_HOTPLUG_EDID_DONE:      on EDID read completion
         */
-       switch (hdmi->hp_state) {
-       case HDMI_HOTPLUG_EDID_DONE:
+       if (hdmi->hp_state == HDMI_HOTPLUG_EDID_DONE) {
                /* PS mode d->e. All functions are active */
                hdmi_write(hdmi, 0x80, HDMI_SYSTEM_CTRL);
                dev_dbg(hdmi->dev, "HDMI running\n");
-               break;
-       default:
-               fb_var_to_videomode(&hdmi->mode, &ch->display_var);
-               break;
        }
 
        return hdmi->hp_state == HDMI_HOTPLUG_DISCONNECTED