netfilter: ip6t_SYNPROXY: unnecessary to check whether ip6_route_output returns NULL
authorLiping Zhang <liping.zhang@spreadtrum.com>
Fri, 22 Apr 2016 09:56:57 +0000 (02:56 -0700)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 25 Apr 2016 13:34:30 +0000 (15:34 +0200)
ip6_route_output() will never return a NULL pointer, so there's no need
to check it.

Signed-off-by: Liping Zhang <liping.zhang@spreadtrum.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv6/netfilter/ip6t_SYNPROXY.c

index 5d778dd11f665fe5368090888d09be8122e99713..06bed74cf5ee0667a86e284289ed23cafeb015cb 100644 (file)
@@ -60,7 +60,7 @@ synproxy_send_tcp(struct net *net,
        fl6.fl6_dport = nth->dest;
        security_skb_classify_flow((struct sk_buff *)skb, flowi6_to_flowi(&fl6));
        dst = ip6_route_output(net, NULL, &fl6);
-       if (dst == NULL || dst->error) {
+       if (dst->error) {
                dst_release(dst);
                goto free_nskb;
        }