tracing/probes: Do not use return value of trace_seq_printf()
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Wed, 12 Nov 2014 22:19:51 +0000 (17:19 -0500)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 19 Nov 2014 20:25:44 +0000 (15:25 -0500)
The functions trace_seq_printf() and friends will soon not have a return
value and will only be a void function. Use trace_seq_has_overflowed()
instead to know if the trace_seq operations succeeded or not.

Link: http://lkml.kernel.org/r/20141114011411.530216306@goodmis.org
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_probe.c

index d4b9fc22cd27fb0a87029424afde729a2b843a4d..b983b2fd2ca171343d188739d245f8579eade04c 100644 (file)
@@ -40,7 +40,8 @@ const char *reserved_field_names[] = {
 int PRINT_TYPE_FUNC_NAME(type)(struct trace_seq *s, const char *name,  \
                                void *data, void *ent)                  \
 {                                                                      \
-       return trace_seq_printf(s, " %s=" fmt, name, *(type *)data);    \
+       trace_seq_printf(s, " %s=" fmt, name, *(type *)data);           \
+       return !trace_seq_has_overflowed(s);                            \
 }                                                                      \
 const char PRINT_TYPE_FMT_NAME(type)[] = fmt;                          \
 NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(type));
@@ -61,10 +62,11 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, const char *name,
        int len = *(u32 *)data >> 16;
 
        if (!len)
-               return trace_seq_printf(s, " %s=(fault)", name);
+               trace_seq_printf(s, " %s=(fault)", name);
        else
-               return trace_seq_printf(s, " %s=\"%s\"", name,
-                                       (const char *)get_loc_data(data, ent));
+               trace_seq_printf(s, " %s=\"%s\"", name,
+                                (const char *)get_loc_data(data, ent));
+       return !trace_seq_has_overflowed(s);
 }
 NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));