niu: timeout ignored in tcam_wait_bit()
authorroel kluin <roel.kluin@gmail.com>
Sun, 27 Dec 2009 04:10:59 +0000 (04:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Jan 2010 05:42:52 +0000 (21:42 -0800)
With `while (--limit > 0)' i reaches 0 after the loop, so upon timeout the
error was not returned.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/niu.c

index 8ce58c4c7dd341ada61278a0cc7e3745c9515ca9..2aed2b382c409358bd5a72c42694ea1ea117da15 100644 (file)
@@ -2844,7 +2844,7 @@ static int tcam_wait_bit(struct niu *np, u64 bit)
                        break;
                udelay(1);
        }
-       if (limit < 0)
+       if (limit <= 0)
                return -ENODEV;
 
        return 0;