drm/bridge: tfp410: fix memleak in get_modes()
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Mon, 10 Jun 2019 13:57:38 +0000 (16:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Sep 2019 08:20:47 +0000 (10:20 +0200)
[ Upstream commit c08f99c39083ab55a9c93b3e93cef48711294dad ]

We don't free the edid blob allocated by the call to drm_get_edid(),
causing a memleak. Fix this by calling kfree(edid) at the end of the
get_modes().

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190610135739.6077-1-tomi.valkeinen@ti.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/ti-tfp410.c

index acb857030951a0eff0682fce7b5d38d80ba6edb1..1bb01905be8e3f6f709b83d2384cb2dd5b8da156 100644 (file)
@@ -64,7 +64,12 @@ static int tfp410_get_modes(struct drm_connector *connector)
 
        drm_mode_connector_update_edid_property(connector, edid);
 
-       return drm_add_edid_modes(connector, edid);
+       ret = drm_add_edid_modes(connector, edid);
+
+       kfree(edid);
+
+       return ret;
+
 fallback:
        /* No EDID, fallback on the XGA standard modes */
        ret = drm_add_modes_noedid(connector, 1920, 1200);