IPS driver: Fix limit clamping when reducing CPU power
authorMatthew Garrett <mjg@redhat.com>
Tue, 5 Oct 2010 18:54:06 +0000 (14:54 -0400)
committerMatthew Garrett <mjg@redhat.com>
Tue, 5 Oct 2010 18:59:35 +0000 (14:59 -0400)
Values here are in internal units rather than Watts, so we shouldn't
perform any conversion.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/intel_ips.c

index 4b3ecdefd6e99d063d3b87fa441783bdaa1f9a8c..c44a5e8b8b82da9d06706d9cd3a3ec0fcb2b883c 100644 (file)
@@ -415,7 +415,7 @@ static void ips_cpu_lower(struct ips_driver *ips)
        new_limit = cur_limit - 8; /* 1W decrease */
 
        /* Clamp to SKU TDP limit */
-       if (((new_limit * 10) / 8) < (ips->orig_turbo_limit & TURBO_TDP_MASK))
+       if (new_limit  < (ips->orig_turbo_limit & TURBO_TDP_MASK))
                new_limit = ips->orig_turbo_limit & TURBO_TDP_MASK;
 
        thm_writew(THM_MPCPC, (new_limit * 10) / 8);