Revert "hda_intel suspend latency: shorten codec read"
authorLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 8 Jan 2008 19:46:37 +0000 (11:46 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 8 Jan 2008 19:46:37 +0000 (11:46 -0800)
This reverts commit 57a04513cb35086d54bcb2cb92e6627fc8fa0fae.

Harald Dunkel reports that it broke sound for him:
  "Alsa stopped working for me.  I still can access /dev/dsp, change the
   volume and so on, but the speakers are quiet."

Reverting it fixed things for him.

Reported-and-tested-by: Harald Dunkel <harald.dunkel@t-online.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
sound/pci/hda/hda_intel.c

index 62b9fb3869030802cfe6bb5dbc72b6750db104c7..3fa0f9704909764e154da625082251b5e0ef9e26 100644 (file)
@@ -555,8 +555,7 @@ static unsigned int azx_rirb_get_response(struct hda_codec *codec)
                }
                if (!chip->rirb.cmds)
                        return chip->rirb.res; /* the last value */
-               udelay(10);
-               cond_resched();
+               schedule_timeout_uninterruptible(1);
        } while (time_after_eq(timeout, jiffies));
 
        if (chip->msi) {