regmap: Fix regmap_bulk_read in BE mode
authorArun Chandran <achandran@mvista.com>
Mon, 15 Jun 2015 10:29:02 +0000 (15:59 +0530)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:09:08 +0000 (13:09 +0000)
commit 15b8d2c41fe5839582029f65c5f7004db451cc2b upstream.

In big endian mode regmap_bulk_read gives incorrect data
for byte reads.

This is because memcpy of a single byte from an address
after full word read gives different results when
endianness differs. ie. we get little-end in LE and big-end in BE.

Signed-off-by: Arun Chandran <achandran@mvista.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/regmap/regmap.c

index fc48e0d244be67eced668c666fb83bbd71bc7688..ab5c65b7747a741c4ae1c35241c492cbb5f0ef79 100644 (file)
@@ -1676,7 +1676,7 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val,
                                          &ival);
                        if (ret != 0)
                                return ret;
-                       memcpy(val + (i * val_bytes), &ival, val_bytes);
+                       map->format.format_val(val + (i * val_bytes), ival, 0);
                }
        }