USB: EHCI: convert warning messages to debug-level
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 19 Sep 2012 21:02:29 +0000 (17:02 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Sep 2012 16:37:53 +0000 (09:37 -0700)
This patch (as1606) converts two warning messages in the ehci-hcd
driver to debug messages, and adds a little extra information to each.

The log messages occur when an EHCI controller takes too long (more
than 20 ms) to turn its async or periodic schedule on or off.  If this
happens at all, it's liable to happen quite often and there's no point
spamming the system log with these warnings.  Furthermore, there's
nothing much we can do about it when the problem happens.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-tested-by: Thomas Voegtle <tv@lio96.de>
Cc: stable <stable@vger.kernel.org> # [3.6]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-timer.c

index eb896a2c8f2ed97fbc4e2cab651e1bb9dca4af11..20dbdcbe9b0fc1fb1330da115bebb3546e45b8f2 100644 (file)
@@ -118,7 +118,8 @@ static void ehci_poll_ASS(struct ehci_hcd *ehci)
                        ehci_enable_event(ehci, EHCI_HRTIMER_POLL_ASS, true);
                        return;
                }
-               ehci_warn(ehci, "Waited too long for the async schedule status, giving up\n");
+               ehci_dbg(ehci, "Waited too long for the async schedule status (%x/%x), giving up\n",
+                               want, actual);
        }
        ehci->ASS_poll_count = 0;
 
@@ -163,7 +164,8 @@ static void ehci_poll_PSS(struct ehci_hcd *ehci)
                        ehci_enable_event(ehci, EHCI_HRTIMER_POLL_PSS, true);
                        return;
                }
-               ehci_warn(ehci, "Waited too long for the periodic schedule status, giving up\n");
+               ehci_dbg(ehci, "Waited too long for the periodic schedule status (%x/%x), giving up\n",
+                               want, actual);
        }
        ehci->PSS_poll_count = 0;