staging/rdma/hfi1: Fix comparison to NULL

Convert pointer comparisons to NULL to !pointer
to fix checkpatch check:
CHECK: Comparison to NULL could be written "!pointer"

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index cf578654e48b86fe69c1c9bcb3b4ccf8e4767c9c..ea0ffd467cdfc025ed29def05a8b092b94fac5ee 100644 (file)
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers/staging/rdma/hfi1/chip.c
@@ -12260,7 +12260,7 @@ u64 hfi1_gpio_mod(struct hfi1_devdata *dd, u32 target, u32 data, u32 dir,
 
 int hfi1_init_ctxt(struct send_context *sc)
 {
-       if (sc != NULL) {
+       if (sc) {
                struct hfi1_devdata *dd = sc->dd;
                u64 reg;
                u8 set = (sc->type == SC_USER ?
@@ -12371,7 +12371,7 @@ static void clean_up_interrupts(struct hfi1_devdata *dd)
                struct hfi1_msix_entry *me = dd->msix_entries;
 
                for (i = 0; i < dd->num_msix_entries; i++, me++) {
-                       if (me->arg == NULL) /* => no irq, no affinity */
+                       if (!me->arg) /* => no irq, no affinity */
                                continue;
                        hfi1_put_irq_affinity(dd, &dd->msix_entries[i]);
                        free_irq(me->msix.vector, me->arg);
@@ -12534,7 +12534,7 @@ static int request_msix_irqs(struct hfi1_devdata *dd)
                        continue;
                }
                /* no argument, no interrupt */
-               if (arg == NULL)
+               if (!arg)
                        continue;
                /* make sure the name is terminated */
                me->name[sizeof(me->name) - 1] = 0;

diff --git a/drivers/staging/rdma/hfi1/debugfs.c b/drivers/staging/rdma/hfi1/debugfs.c
index f309c5fd7b74b72edd412cce532e36e0137614c2..fa3df1f75f5dd6b287fb984c73ab159c7007dd52 100644 (file)
--- a/drivers/staging/rdma/hfi1/debugfs.c
+++ b/drivers/staging/rdma/hfi1/debugfs.c
@@ -746,7 +746,7 @@ void hfi1_dbg_ibdev_init(struct hfi1_ibdev *ibd)
                                            ibd->hfi1_ibdev_dbg,
                                            ppd,
                                            &port_cntr_ops[i].ops,
-                                           port_cntr_ops[i].ops.write == NULL ?
+                                           !port_cntr_ops[i].ops.write ?
                                            S_IRUGO : S_IRUGO | S_IWUSR);
                }
 }

diff --git a/drivers/staging/rdma/hfi1/driver.c b/drivers/staging/rdma/hfi1/driver.c
index 6082935bc4351bc96b59cfcf385ce1a5fa628489..0c8bd917424598218d48ec9d2be3e5f9dd02f9ee 100644 (file)
--- a/drivers/staging/rdma/hfi1/driver.c
+++ b/drivers/staging/rdma/hfi1/driver.c
@@ -371,7 +371,7 @@ static void rcv_hdrerr(struct hfi1_ctxtdata *rcd, struct hfi1_pportdata *ppd,
                if (rhf_use_egr_bfr(packet->rhf))
                        ebuf = packet->ebuf;
 
-               if (ebuf == NULL)
+               if (!ebuf)
                        goto drop; /* this should never happen */
 
                if (lnh == HFI1_LRH_BTH)
@@ -402,7 +402,7 @@ static void rcv_hdrerr(struct hfi1_ctxtdata *rcd, struct hfi1_pportdata *ppd,
                        lqpn = be32_to_cpu(bth[1]) & RVT_QPN_MASK;
                        rcu_read_lock();
                        qp = rvt_lookup_qpn(rdi, &ibp->rvp, lqpn);
-                       if (qp == NULL) {
+                       if (!qp) {
                                rcu_read_unlock();
                                goto drop;
                        }
@@ -637,7 +637,7 @@ static void __prescan_rxq(struct hfi1_packet *packet)
                rcu_read_lock();
                qp = rvt_lookup_qpn(rdi, &ibp->rvp, qpn);
 
-               if (qp == NULL) {
+               if (!qp) {
                        rcu_read_unlock();
                        goto next;
                }

diff --git a/drivers/staging/rdma/hfi1/init.c b/drivers/staging/rdma/hfi1/init.c
index 3071fbce37f75a829bdc414ffc820141867a617d..aabdc3d9d50831a221c024aad58d53043345c8b4 100644 (file)
--- a/drivers/staging/rdma/hfi1/init.c
+++ b/drivers/staging/rdma/hfi1/init.c
@@ -386,7 +386,7 @@ void set_link_ipg(struct hfi1_pportdata *ppd)
 
        cc_state = get_cc_state(ppd);
 
-       if (cc_state == NULL)
+       if (!cc_state)
                /*
                 * This should _never_ happen - rcu_read_lock() is held,
                 * and set_link_ipg() should not be called if cc_state
@@ -438,7 +438,7 @@ static enum hrtimer_restart cca_timer_fn(struct hrtimer *t)
 
        cc_state = get_cc_state(ppd);
 
-       if (cc_state == NULL) {
+       if (!cc_state) {
                rcu_read_unlock();
                return HRTIMER_NORESTART;
        }

diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c
index a56d7dc2d0201c368f9863762f809f3f542f6e37..44e7fbd376467805c00e957eadfb082c79bfd362 100644 (file)
--- a/drivers/staging/rdma/hfi1/mad.c
+++ b/drivers/staging/rdma/hfi1/mad.c
@@ -3297,7 +3297,7 @@ static int __subn_get_opa_cong_setting(struct opa_smp *smp, u32 am,
 
        cc_state = get_cc_state(ppd);
 
-       if (cc_state == NULL) {
+       if (!cc_state) {
                rcu_read_unlock();
                return reply((struct ib_mad_hdr *)smp);
        }
@@ -3439,7 +3439,7 @@ static int __subn_get_opa_cc_table(struct opa_smp *smp, u32 am, u8 *data,
 
        cc_state = get_cc_state(ppd);
 
-       if (cc_state == NULL) {
+       if (!cc_state) {
                rcu_read_unlock();
                return reply((struct ib_mad_hdr *)smp);
        }
@@ -3505,14 +3505,14 @@ static int __subn_set_opa_cc_table(struct opa_smp *smp, u32 am, u8 *data,
        }
 
        new_cc_state = kzalloc(sizeof(*new_cc_state), GFP_KERNEL);
-       if (new_cc_state == NULL)
+       if (!new_cc_state)
                goto getit;
 
        spin_lock(&ppd->cc_state_lock);
 
        old_cc_state = get_cc_state(ppd);
 
-       if (old_cc_state == NULL) {
+       if (!old_cc_state) {
                spin_unlock(&ppd->cc_state_lock);
                kfree(new_cc_state);
                return reply((struct ib_mad_hdr *)smp);

diff --git a/drivers/staging/rdma/hfi1/pio.c b/drivers/staging/rdma/hfi1/pio.c
index 3817731832ecd639d10c803d186dad740bf3b042..7907e4c268d87c75e4fe87b82ba93a752a0ad917 100644 (file)
--- a/drivers/staging/rdma/hfi1/pio.c
+++ b/drivers/staging/rdma/hfi1/pio.c
@@ -2002,7 +2002,7 @@ int init_credit_return(struct hfi1_devdata *dd)
                                        bytes,
                                        &dd->cr_base[i].pa,
                                        GFP_KERNEL);
-               if (dd->cr_base[i].va == NULL) {
+               if (!dd->cr_base[i].va) {
                        set_dev_node(&dd->pcidev->dev, dd->node);
                        dd_dev_err(dd,
                                "Unable to allocate credit return DMA range for NUMA %d\n",

diff --git a/drivers/staging/rdma/hfi1/rc.c b/drivers/staging/rdma/hfi1/rc.c
index 24f2b6562c54b3b4452cf592f7699e25eaf847a6..99584f7f50528c901273be7dcbbe15716c1c3a5c 100644 (file)
--- a/drivers/staging/rdma/hfi1/rc.c
+++ b/drivers/staging/rdma/hfi1/rc.c
@@ -2025,7 +2025,7 @@ void process_becn(struct hfi1_pportdata *ppd, u8 sl, u16 rlid, u32 lqpn,
 
        cc_state = get_cc_state(ppd);
 
-       if (cc_state == NULL)
+       if (!cc_state)
                return;
 
        /*

diff --git a/drivers/staging/rdma/hfi1/sysfs.c b/drivers/staging/rdma/hfi1/sysfs.c
index 1f3a747ce6666092ca9e43f831f975fcc9d2fa45..3c34f7788873cfdaf93f49c2704518346596d4a8 100644 (file)
--- a/drivers/staging/rdma/hfi1/sysfs.c
+++ b/drivers/staging/rdma/hfi1/sysfs.c
@@ -83,7 +83,7 @@ static ssize_t read_cc_table_bin(struct file *filp, struct kobject *kobj,
 
        rcu_read_lock();
        cc_state = get_cc_state(ppd);
-       if (cc_state == NULL) {
+       if (!cc_state) {
                rcu_read_unlock();
                return -EINVAL;
        }
@@ -130,7 +130,7 @@ static ssize_t read_cc_setting_bin(struct file *filp, struct kobject *kobj,
 
        rcu_read_lock();
        cc_state = get_cc_state(ppd);
-       if (cc_state == NULL) {
+       if (!cc_state) {
                rcu_read_unlock();
                return -EINVAL;
        }

diff --git a/drivers/staging/rdma/hfi1/verbs.c b/drivers/staging/rdma/hfi1/verbs.c
index 466055bd510782258e69500ade8208c3b3ba3ea7..c412f1c6637ccc7551d6ec9973e3007116f6e95f 100644 (file)
--- a/drivers/staging/rdma/hfi1/verbs.c
+++ b/drivers/staging/rdma/hfi1/verbs.c
@@ -431,7 +431,7 @@ void hfi1_ib_rcv(struct hfi1_packet *packet)
                if (lnh != HFI1_LRH_GRH)
                        goto drop;
                mcast = rvt_mcast_find(&ibp->rvp, &hdr->u.l.grh.dgid);
-               if (mcast == NULL)
+               if (!mcast)
                        goto drop;
                list_for_each_entry_rcu(p, &mcast->qp_list, list) {
                        packet->qp = p->qp;
@@ -838,7 +838,7 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
        if (cb)
                iowait_pio_inc(&priv->s_iowait);
        pbuf = sc_buffer_alloc(sc, plen, cb, qp);
-       if (unlikely(pbuf == NULL)) {
+       if (unlikely(!pbuf)) {
                if (cb)
                        verbs_pio_complete(qp, 0);
                if (ppd->host_link_state != HLS_UP_ACTIVE) {