memory: tegra: Delete unneeded of_node_put()

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>

diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index a1ae0cc2b86d50dd24e84cf66871dd3148d86e01..85ce4beb7f03bcd508e574d11cf92488d1820a1c 100644 (file)
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -206,10 +206,8 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc)
        for_each_child_of_node(mc->dev->of_node, node) {
                err = of_property_read_u32(node, "nvidia,ram-code",
                                           &node_ram_code);
-               if (err || (node_ram_code != ram_code)) {
-                       of_node_put(node);
+               if (err || (node_ram_code != ram_code))
                        continue;
-               }
 
                err = load_timings(mc, node);
                if (err)

diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c
index 02a63177c6e7ba4fb2281961c6a81efdd27cdcf5..06cc781ebac18b8dc1e1054a6c89f99717581991 100644 (file)
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -997,10 +997,8 @@ tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code)
                u32 value;
 
                err = of_property_read_u32(np, "nvidia,ram-code", &value);
-               if (err || (value != ram_code)) {
-                       of_node_put(np);
+               if (err || (value != ram_code))
                        continue;
-               }
 
                return np;
        }