Resolve TODO in AclFormField
authorMatthias Schmidt <gravatronics@live.com>
Thu, 2 Aug 2018 16:03:11 +0000 (18:03 +0200)
committerMatthias Schmidt <gravatronics@live.com>
Thu, 2 Aug 2018 16:03:11 +0000 (18:03 +0200)
See #2509

wcfsetup/install/files/lib/system/form/builder/field/AclFormField.class.php

index bd5c2c9c2a20f080e24e30ba07f72476499d424d..7a7aa9895f1c99bf69eae90950876d0a430fc1c6 100644 (file)
@@ -51,7 +51,9 @@ class AclFormField extends AbstractFormField implements IObjectTypeFormField {
         * @throws      \InvalidArgumentException       if given category name is invalid
         */
        public function categoryName($categoryName) {
-               // TODO: validation
+               if (!is_string($categoryName) || !preg_match('~^[A-z0-9\-\_]+(\.[A-z0-9\-\_]+)+$~', $categoryName)) {
+                       throw new \InvalidArgumentException("Invalid category name given.");
+               }
                
                $this->__categoryName = $categoryName;