atheros: atlx: Use setup_timer
authorJulia Lawall <julia.lawall@lip6.fr>
Fri, 26 Dec 2014 14:35:34 +0000 (15:35 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Dec 2014 23:34:23 +0000 (18:34 -0500)
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.function = f;
-t.data = d;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/atlx/atl2.c

index 84a09e8ddd9c92e27a165473aeb2f05d89ac1990..482a7cabb0a1421802e66dce856ea94925c0dd15 100644 (file)
@@ -1436,13 +1436,11 @@ static int atl2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        atl2_check_options(adapter);
 
-       init_timer(&adapter->watchdog_timer);
-       adapter->watchdog_timer.function = atl2_watchdog;
-       adapter->watchdog_timer.data = (unsigned long) adapter;
+       setup_timer(&adapter->watchdog_timer, atl2_watchdog,
+                   (unsigned long)adapter);
 
-       init_timer(&adapter->phy_config_timer);
-       adapter->phy_config_timer.function = atl2_phy_config;
-       adapter->phy_config_timer.data = (unsigned long) adapter;
+       setup_timer(&adapter->phy_config_timer, atl2_phy_config,
+                   (unsigned long)adapter);
 
        INIT_WORK(&adapter->reset_task, atl2_reset_task);
        INIT_WORK(&adapter->link_chg_task, atl2_link_chg_task);