bnx2x: Don't log mc removal needlessly
authorMintz, Yuval <Yuval.Mintz@cavium.com>
Sat, 24 Jun 2017 12:37:00 +0000 (15:37 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Jun 2017 15:36:56 +0000 (11:36 -0400)
When mc configuration changes bnx2x_config_mcast() can return 0 for
success, negative for failure and positive for benign reason preventing
its immediate work, e.g., when the command awaits the completion of
a previously sent command.

When removing all configured macs on a 578xx adapter, if a positive
value would be returned driver would errneously log it as an error.

Fixes: c7b7b483ccc9 ("bnx2x: Don't flush multicast MACs")
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

index a851f95c307a3331a889972bc3c60273219f8a7b..349a46593abff6e4ea80ddd3a79301dac9cca517 100644 (file)
@@ -12729,7 +12729,7 @@ static int bnx2x_set_mc_list(struct bnx2x *bp)
        } else {
                /* If no mc addresses are required, flush the configuration */
                rc = bnx2x_config_mcast(bp, &rparam, BNX2X_MCAST_CMD_DEL);
-               if (rc)
+               if (rc < 0)
                        BNX2X_ERR("Failed to clear multicast configuration %d\n",
                                  rc);
        }