cxgb4: fix memory leak in init_one()
authorGanesh Goudar <ganeshgr@chelsio.com>
Fri, 9 Jun 2017 13:56:24 +0000 (19:26 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Jun 2017 19:52:50 +0000 (15:52 -0400)
Free up mbox_log allocated for PF0 to PF3.

Fixes: 7829451c695e ("cxgb4: Add control net_device for configuring PCIe VF")
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

index ff8bcf56bf3f3647ca4a92fd7839da520cf42321..01c9710fc62e683f883fdab58526b6c66fb7c153 100644 (file)
@@ -5169,13 +5169,15 @@ sriov:
                              &v, &port_vec);
        if (err < 0) {
                dev_err(adapter->pdev_dev, "Could not fetch port params\n");
-               goto free_adapter;
+               goto free_mbox_log;
        }
 
        adapter->params.nports = hweight32(port_vec);
        pci_set_drvdata(pdev, adapter);
        return 0;
 
+free_mbox_log:
+       kfree(adapter->mbox_log);
  free_adapter:
        kfree(adapter);
  free_pci_region:
@@ -5275,6 +5277,7 @@ static void remove_one(struct pci_dev *pdev)
                        unregister_netdev(adapter->port[0]);
                iounmap(adapter->regs);
                kfree(adapter->vfinfo);
+               kfree(adapter->mbox_log);
                kfree(adapter);
                pci_disable_sriov(pdev);
                pci_release_regions(pdev);
@@ -5321,6 +5324,7 @@ static void shutdown_one(struct pci_dev *pdev)
                        unregister_netdev(adapter->port[0]);
                iounmap(adapter->regs);
                kfree(adapter->vfinfo);
+               kfree(adapter->mbox_log);
                kfree(adapter);
                pci_disable_sriov(pdev);
                pci_release_regions(pdev);