drm/nouveau/iccsense: remove read function

Signed-off-by: Karol Herbst <nouveau@karolherbst.de>
Reviewed-by: Martin Peres <martin.peres@free.fr>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

diff --git a/drivers/gpu/drm/nouveau/include/nvkm/subdev/iccsense.h b/drivers/gpu/drm/nouveau/include/nvkm/subdev/iccsense.h
index 530c6215fe4f2d38866fac16ba0a009d27bc4a1b..c3defcd34d51ce23cb09032ecc297ec0afb74481 100644 (file)
--- a/drivers/gpu/drm/nouveau/include/nvkm/subdev/iccsense.h
+++ b/drivers/gpu/drm/nouveau/include/nvkm/subdev/iccsense.h
@@ -12,6 +12,5 @@ struct nvkm_iccsense {
 };
 
 int gf100_iccsense_new(struct nvkm_device *, int index, struct nvkm_iccsense **);
-int nvkm_iccsense_read(struct nvkm_iccsense *iccsense, u8 idx);
 int nvkm_iccsense_read_all(struct nvkm_iccsense *iccsense);
 #endif

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
index c44a85228074e02db3435e29e119e9d3ef7f930e..bf1b94ec6ed47fe089046daed87eeee8fea3ffef 100644 (file)
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -96,26 +96,23 @@ nvkm_iccsense_ina3221_read(struct nvkm_iccsense *iccsense,
 }
 
 int
-nvkm_iccsense_read(struct nvkm_iccsense *iccsense, u8 idx)
+nvkm_iccsense_read_all(struct nvkm_iccsense *iccsense)
 {
-       struct nvkm_iccsense_rail *rail;
+       int result = 0, i;
 
-       if (!iccsense || idx >= iccsense->rail_count)
+       if (!iccsense)
                return -EINVAL;
 
-       rail = &iccsense->rails[idx];
-       if (!rail->read)
+       if (iccsense->rail_count == 0)
                return -ENODEV;
 
-       return rail->read(iccsense, rail);
-}
-
-int
-nvkm_iccsense_read_all(struct nvkm_iccsense *iccsense)
-{
-       int result = 0, i;
        for (i = 0; i < iccsense->rail_count; ++i) {
-               int res = nvkm_iccsense_read(iccsense, i);
+               int res;
+               struct nvkm_iccsense_rail *rail = &iccsense->rails[i];
+               if (!rail->read)
+                       return -ENODEV;
+
+               res = rail->read(iccsense, rail);
                if (res >= 0)
                        result += res;
                else