panic: Fix panic message visibility by calling bust_spinlocks(0) before dying
authorAaro Koskinen <aaro.koskinen@nokia.com>
Fri, 2 Oct 2009 11:41:20 +0000 (14:41 +0300)
committerIngo Molnar <mingo@elte.hu>
Mon, 5 Oct 2009 19:08:09 +0000 (21:08 +0200)
Commit ffd71da4e3f ("panic: decrease oops_in_progress only after
having done the panic") moved bust_spinlocks(0) to the end of the
function, which in practice is never reached.

As a result console_unblank() is not called, and on some systems
the user may not see the panic message.

Move it back up to before the unblanking.

Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1254483680-25578-1-git-send-email-aaro.koskinen@nokia.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/panic.c

index 512ab73b0ca3afed1553b5e01218c92d17630a4c..bc4dcb6a389b0c7cdbeb686bc1898630c13e87b7 100644 (file)
@@ -90,6 +90,8 @@ NORET_TYPE void panic(const char * fmt, ...)
 
        atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
 
+       bust_spinlocks(0);
+
        if (!panic_blink)
                panic_blink = no_blink;
 
@@ -136,7 +138,6 @@ NORET_TYPE void panic(const char * fmt, ...)
                mdelay(1);
                i++;
        }
-       bust_spinlocks(0);
 }
 
 EXPORT_SYMBOL(panic);