comedi: ni_6527: Fix coding style - use BIT macro
authorRanjith Thangavel <ranjithece24@gmail.com>
Mon, 16 Nov 2015 16:56:15 +0000 (22:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Dec 2015 23:56:01 +0000 (15:56 -0800)
BIT macro is used for defining BIT location instead of
shifting operator - coding style issue

Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_6527.c

index 62a817e4cd64582b14e3afe1c101066d89276695..84c62e25609435493838b85139b45867e5c7aaca 100644 (file)
 #define NI6527_DO_REG(x)               (0x03 + (x))
 #define NI6527_ID_REG                  0x06
 #define NI6527_CLR_REG                 0x07
-#define NI6527_CLR_EDGE                        (1 << 3)
-#define NI6527_CLR_OVERFLOW            (1 << 2)
-#define NI6527_CLR_FILT                        (1 << 1)
-#define NI6527_CLR_INTERVAL            (1 << 0)
+#define NI6527_CLR_EDGE                        BIT(3)
+#define NI6527_CLR_OVERFLOW            BIT(2)
+#define NI6527_CLR_FILT                        BIT(1)
+#define NI6527_CLR_INTERVAL            BIT(0)
 #define NI6527_CLR_IRQS                        (NI6527_CLR_EDGE | NI6527_CLR_OVERFLOW)
 #define NI6527_CLR_RESET_FILT          (NI6527_CLR_FILT | NI6527_CLR_INTERVAL)
 #define NI6527_FILT_INTERVAL_REG(x)    (0x08 + (x))
 #define NI6527_FILT_ENA_REG(x)         (0x0c + (x))
 #define NI6527_STATUS_REG              0x14
-#define NI6527_STATUS_IRQ              (1 << 2)
-#define NI6527_STATUS_OVERFLOW         (1 << 1)
-#define NI6527_STATUS_EDGE             (1 << 0)
+#define NI6527_STATUS_IRQ              BIT(2)
+#define NI6527_STATUS_OVERFLOW         BIT(1)
+#define NI6527_STATUS_EDGE             BIT(0)
 #define NI6527_CTRL_REG                        0x15
-#define NI6527_CTRL_FALLING            (1 << 4)
-#define NI6527_CTRL_RISING             (1 << 3)
-#define NI6527_CTRL_IRQ                        (1 << 2)
-#define NI6527_CTRL_OVERFLOW           (1 << 1)
-#define NI6527_CTRL_EDGE               (1 << 0)
+#define NI6527_CTRL_FALLING            BIT(4)
+#define NI6527_CTRL_RISING             BIT(3)
+#define NI6527_CTRL_IRQ                        BIT(2)
+#define NI6527_CTRL_OVERFLOW           BIT(1)
+#define NI6527_CTRL_EDGE               BIT(0)
 #define NI6527_CTRL_DISABLE_IRQS       0
 #define NI6527_CTRL_ENABLE_IRQS                (NI6527_CTRL_FALLING | \
                                         NI6527_CTRL_RISING | \