mac80211: don't flush when probing the AP
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Mon, 20 Oct 2014 12:57:18 +0000 (15:57 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 27 Oct 2014 07:48:34 +0000 (08:48 +0100)
All the callers of ieee80211_mgd_probe_ap_send return right
after they call the flush() callback. This means that calling
flush() is uneeded since its meaning is to wait until the
queues of the device are empty.

Devices that know how to report status on Tx will do so using
the regular path (ieee80211_tx_status) and this status will
trigger the continuation of the flow of the probe
(ieee80211_sta_tx_notify).

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c

index 4d9b4d165ce88d2fb0a2c3b53c6283766b5b0b62..c078cd344ca46b963f8c10890c4251b22631adc2 100644 (file)
@@ -2207,8 +2207,6 @@ static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data *sdata)
 
        ifmgd->probe_timeout = jiffies + msecs_to_jiffies(probe_wait_ms);
        run_again(sdata, ifmgd->probe_timeout);
-       if (sdata->local->hw.flags & IEEE80211_HW_REPORTS_TX_ACK_STATUS)
-               ieee80211_flush_queues(sdata->local, sdata);
 }
 
 static void ieee80211_mgd_probe_ap(struct ieee80211_sub_if_data *sdata,