Improved a11y
authorMarcel Werk <burntime@woltlab.com>
Tue, 10 Sep 2019 17:34:14 +0000 (19:34 +0200)
committerMarcel Werk <burntime@woltlab.com>
Tue, 10 Sep 2019 17:34:14 +0000 (19:34 +0200)
wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/Header/Menu.js
wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Page/JumpToTop.js

index 5801bf3f82c731206bb8697fcf0e5e51c544eeed..4b56f1d55abe1dfecb657332a96d8688ec221a81 100644 (file)
@@ -180,6 +180,7 @@ define(['Environment', 'Language', 'Ui/Screen'], function(Environment, Language,
                        _buttonShowNext.className = 'mainMenuShowNext';
                        _buttonShowNext.href = '#';
                        _buttonShowNext.innerHTML = '<span class="icon icon32 fa-angle-right"></span>';
+                       elAttr(_buttonShowNext, 'aria-hidden', 'true');
                        _buttonShowNext.addEventListener(WCF_CLICK_EVENT, this._showNext.bind(this));
                        
                        _menu.parentNode.appendChild(_buttonShowNext);
@@ -188,6 +189,7 @@ define(['Environment', 'Language', 'Ui/Screen'], function(Environment, Language,
                        _buttonShowPrevious.className = 'mainMenuShowPrevious';
                        _buttonShowPrevious.href = '#';
                        _buttonShowPrevious.innerHTML = '<span class="icon icon32 fa-angle-left"></span>';
+                       elAttr(_buttonShowPrevious, 'aria-hidden', 'true');
                        _buttonShowPrevious.addEventListener(WCF_CLICK_EVENT, this._showPrevious.bind(this));
                        
                        _menu.parentNode.insertBefore(_buttonShowPrevious, _menu.parentNode.firstChild);
index 4b961da75d166ed70dec0a82c72bc8e92b853009..27e6d9d40206f807ef15e6b2164bbe1124493c0f 100644 (file)
@@ -30,7 +30,7 @@ define(['Environment', 'Language', './Action'], function(Environment, Language,
                        button.className = 'jsTooltip';
                        button.href = '#';
                        elAttr(button, 'title', Language.get('wcf.global.scrollUp'));
-                       elAttr(button, 'role', 'button');
+                       elAttr(button, 'aria-hidden', 'true');
                        button.innerHTML = '<span class="icon icon32 fa-angle-up"></span>';
                        
                        button.addEventListener(WCF_CLICK_EVENT, this._jump.bind(this));