Revert "cpufreq: Fix governor module removal race"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Apr 2018 07:06:23 +0000 (09:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 8 Apr 2018 12:26:34 +0000 (14:26 +0200)
This reverts commit 0049457bfde661cf47410eaacad65845c9a2bb45 which was
commit a8b149d32b663c1a4105273295184b78f53d33cf upstream.

The backport was not correct, so just drop it entirely.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cpufreq/cpufreq.c

index bb1e148ebfd4c5494cb681458f8bcca540fcd0d8..ea43b147a7fe93adc3c8229327532debec429486 100644 (file)
@@ -631,8 +631,6 @@ static int cpufreq_parse_governor(char *str_governor, unsigned int *policy,
                        *governor = t;
                        err = 0;
                }
-               if (t && !try_module_get(t->owner))
-                       t = NULL;
 
                mutex_unlock(&cpufreq_governor_mutex);
        }
@@ -761,10 +759,6 @@ static ssize_t store_scaling_governor(struct cpufreq_policy *policy,
                return -EINVAL;
 
        ret = cpufreq_set_policy(policy, &new_policy);
-
-       if (new_policy.governor)
-               module_put(new_policy.governor->owner);
-
        return ret ? ret : count;
 }