projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 2eb03e6)
net: hns: mdio->irq is an array, so no need to check if it is null
authorColin Ian King <colin.king@canonical.com>
Mon, 15 Aug 2016 12:55:17 +0000 (13:55 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Aug 2016 20:38:44 +0000 (13:38 -0700)
The null check on mdio->irq is redundant since mdio->irq is an array
of PHY_MAX_ADDR ints and hence can never be null. Remove the redundant
check.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c patch | blob | blame | history

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index 5c8afe1a5ccb1d35c0e545c92212e3b7c2428ac9..a834774fdb02d01d5968556391ea2e8197f37dac 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -684,8 +684,7 @@ hns_mac_register_phydev(struct mii_bus *mdio, struct hns_mac_cb *mac_cb,
        if (!phy || IS_ERR(phy))
                return -EIO;
 
-       if (mdio->irq)
-               phy->irq = mdio->irq[addr];
+       phy->irq = mdio->irq[addr];
 
        /* All data is now stored in the phy struct;
         * register it