projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: ee51f44)
qla2xxx: Remove redundant NULL check before release_firmware() call.
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 20:51:41 +0000 (22:51 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 30 Apr 2012 11:23:57 +0000 (13:23 +0200)
release_firmware() checks for NULL pointers internally so checking
before calling it is redundant.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/scsi/qla2xxx/qla_os.c patch | blob | blame | history

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index a2f999273a5fa5e9d9a2a3328df54524b1b5fe75..91b6fe6000eb8b9c3b377f46cb99c45b32528151 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void)
 
        mutex_lock(&qla_fw_lock);
        for (idx = 0; idx < FW_BLOBS; idx++)
-               if (qla_fw_blobs[idx].fw)
-                       release_firmware(qla_fw_blobs[idx].fw);
+               release_firmware(qla_fw_blobs[idx].fw);
        mutex_unlock(&qla_fw_lock);
 }