scsi: pm8001: Fix payload initialization in pm80xx_set_thermal_config()
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>
Sun, 20 Feb 2022 03:17:46 +0000 (12:17 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:17 +0000 (09:08 +0200)
[ Upstream commit bb225b12dbcc82d53d637d10b8d70b64494f8c16 ]

The fields of the set_ctrl_cfg_req structure have the __le32 type, so use
cpu_to_le32() to assign them. This removes the sparse warnings:

warning: incorrect type in assignment (different base types)
    expected restricted __le32
    got unsigned int

Link: https://lore.kernel.org/r/20220220031810.738362-8-damien.lemoal@opensource.wdc.com
Fixes: 842784e0d15b ("pm80xx: Update For Thermal Page Code")
Fixes: f5860992db55 ("[SCSI] pm80xx: Added SPCv/ve specific hardware functionalities and relevant changes in common files")
Reviewed-by: John Garry <john.garry@huawei.com>
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/pm8001/pm80xx_hwi.c

index 162b819f3a89da61f90c674c220d5fab0b1fc0ed..cf037e076235364531a976183b9fc639643c4b3d 100644 (file)
@@ -870,9 +870,11 @@ pm80xx_set_thermal_config(struct pm8001_hba_info *pm8001_ha)
        else
                page_code = THERMAL_PAGE_CODE_8H;
 
-       payload.cfg_pg[0] = (THERMAL_LOG_ENABLE << 9) |
-                               (THERMAL_ENABLE << 8) | page_code;
-       payload.cfg_pg[1] = (LTEMPHIL << 24) | (RTEMPHIL << 8);
+       payload.cfg_pg[0] =
+               cpu_to_le32((THERMAL_LOG_ENABLE << 9) |
+                           (THERMAL_ENABLE << 8) | page_code);
+       payload.cfg_pg[1] =
+               cpu_to_le32((LTEMPHIL << 24) | (RTEMPHIL << 8));
 
        rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &payload, 0);
        if (rc)