USB: missing error check in emi26
authorOliver Neukum <oliver@neukum.org>
Thu, 25 Oct 2007 13:38:44 +0000 (15:38 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 25 Oct 2007 19:18:45 +0000 (12:18 -0700)
this drivers lacks an error check.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/emi26.c

index cd137577bb2d06b1c6278cb601e30590d6929481..4a09b87bdd2835b20528da8748e2ea5bb5224454 100644 (file)
@@ -114,6 +114,10 @@ static int emi26_load_firmware (struct usb_device *dev)
 
        /* De-assert reset (let the CPU run) */
        err = emi26_set_reset(dev,0);
+       if (err < 0) {
+               err("%s - error loading firmware: error = %d", __FUNCTION__, err);
+               goto wraperr;
+       }
        msleep(250);    /* let device settle */
 
        /* 2. We upload the FPGA firmware into the EMI