brcmfmac: fix a double spin_unlock_irqrestore issue in dpc
authorFranky Lin <frankyl@broadcom.com>
Mon, 30 Apr 2012 18:43:07 +0000 (11:43 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 2 May 2012 18:02:03 +0000 (14:02 -0400)
dpc_tl_lock is not acquired in the error handle code for bus down.
But it's unlocked using spin_unlock_irqrestore after finishing task
list walk down. Grab the lock before breaking the loop to avoid a
double unlock.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c

index eb3829b03cd37cf587edab5e4e12aa839e6635e0..e2b34e1563f4a34624116ba8c927d983206cddb9 100644 (file)
@@ -2637,6 +2637,7 @@ static int brcmf_sdbrcm_dpc_thread(void *data)
                                /* after stopping the bus, exit thread */
                                brcmf_sdbrcm_bus_stop(bus->sdiodev->dev);
                                bus->dpc_tsk = NULL;
+                               spin_lock_irqsave(&bus->dpc_tl_lock, flags);
                                break;
                        }