PCI: Remove pci_resource_bar() and pci_iov_resource_bar()

From: Bjorn Helgaas <bhelgaas@google.com>

[ Upstream commit 286c2378aaccc7343ebf17ec6cd86567659caf70 ]

pci_std_update_resource() only deals with standard BARs, so we don't have
to worry about the complications of VF BARs in an SR-IOV capability.

Compute the BAR address inline and remove pci_resource_bar().  That makes
pci_iov_resource_bar() unused, so remove that as well.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index a6b1001683967949e5ee963c3bfb308756869645..2f8ea6f84c97d11a4d41a84e06693301d94204d4 100644 (file)
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -554,24 +554,6 @@ void pci_iov_release(struct pci_dev *dev)
                sriov_release(dev);
 }
 
-/**
- * pci_iov_resource_bar - get position of the SR-IOV BAR
- * @dev: the PCI device
- * @resno: the resource number
- *
- * Returns position of the BAR encapsulated in the SR-IOV capability.
- */
-int pci_iov_resource_bar(struct pci_dev *dev, int resno)
-{
-       if (resno < PCI_IOV_RESOURCES || resno > PCI_IOV_RESOURCE_END)
-               return 0;
-
-       BUG_ON(!dev->is_physfn);
-
-       return dev->sriov->pos + PCI_SRIOV_BAR +
-               4 * (resno - PCI_IOV_RESOURCES);
-}
-
 /**
  * pci_iov_update_resource - update a VF BAR
  * @dev: the PCI device

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index e311a9bf2c90d602e3ced4725b22562c733660cf..a01e6d5fedec426f7dd6b47ea4ae864658daf168 100644 (file)
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4472,36 +4472,6 @@ int pci_select_bars(struct pci_dev *dev, unsigned long flags)
 }
 EXPORT_SYMBOL(pci_select_bars);
 
-/**
- * pci_resource_bar - get position of the BAR associated with a resource
- * @dev: the PCI device
- * @resno: the resource number
- * @type: the BAR type to be filled in
- *
- * Returns BAR position in config space, or 0 if the BAR is invalid.
- */
-int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type)
-{
-       int reg;
-
-       if (resno < PCI_ROM_RESOURCE) {
-               *type = pci_bar_unknown;
-               return PCI_BASE_ADDRESS_0 + 4 * resno;
-       } else if (resno == PCI_ROM_RESOURCE) {
-               *type = pci_bar_mem32;
-               return dev->rom_base_reg;
-       } else if (resno < PCI_BRIDGE_RESOURCES) {
-               /* device specific resource */
-               *type = pci_bar_unknown;
-               reg = pci_iov_resource_bar(dev, resno);
-               if (reg)
-                       return reg;
-       }
-
-       dev_err(&dev->dev, "BAR %d: invalid resource\n", resno);
-       return 0;
-}
-
 /* Some architectures require additional programming to enable VGA */
 static arch_set_vga_state_t arch_set_vga_state;
 

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index eda77d1baec1157ca7fc87820e65a7d30e38fd7b..c43e448873ca9ee877c127f20181acc429d23bf7 100644 (file)
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -232,7 +232,6 @@ bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *pl,
 int pci_setup_device(struct pci_dev *dev);
 int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
                    struct resource *res, unsigned int reg);
-int pci_resource_bar(struct pci_dev *dev, int resno, enum pci_bar_type *type);
 void pci_configure_ari(struct pci_dev *dev);
 void __pci_bus_size_bridges(struct pci_bus *bus,
                        struct list_head *realloc_head);
@@ -276,7 +275,6 @@ static inline void pci_restore_ats_state(struct pci_dev *dev)
 #ifdef CONFIG_PCI_IOV
 int pci_iov_init(struct pci_dev *dev);
 void pci_iov_release(struct pci_dev *dev);
-int pci_iov_resource_bar(struct pci_dev *dev, int resno);
 void pci_iov_update_resource(struct pci_dev *dev, int resno);
 resource_size_t pci_sriov_resource_alignment(struct pci_dev *dev, int resno);
 void pci_restore_iov_state(struct pci_dev *dev);
@@ -291,10 +289,6 @@ static inline void pci_iov_release(struct pci_dev *dev)
 
 {
 }
-static inline int pci_iov_resource_bar(struct pci_dev *dev, int resno)
-{
-       return 0;
-}
 static inline void pci_restore_iov_state(struct pci_dev *dev)
 {
 }

diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index ac58c566fb1a382c49a8c84911f418c38dd25de0..674e76c9334ef979ac7dccce0f3801ab40b7c6d5 100644 (file)
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -32,7 +32,6 @@ static void pci_std_update_resource(struct pci_dev *dev, int resno)
        u16 cmd;
        u32 new, check, mask;
        int reg;
-       enum pci_bar_type type;
        struct resource *res = dev->resource + resno;
 
        if (dev->is_virtfn) {
@@ -66,14 +65,16 @@ static void pci_std_update_resource(struct pci_dev *dev, int resno)
        else
                mask = (u32)PCI_BASE_ADDRESS_MEM_MASK;
 
-       reg = pci_resource_bar(dev, resno, &type);
-       if (!reg)
-               return;
-       if (type != pci_bar_unknown) {
+       if (resno < PCI_ROM_RESOURCE) {
+               reg = PCI_BASE_ADDRESS_0 + 4 * resno;
+       } else if (resno == PCI_ROM_RESOURCE) {
                if (!(res->flags & IORESOURCE_ROM_ENABLE))
                        return;
+
+               reg = dev->rom_base_reg;
                new |= PCI_ROM_ADDRESS_ENABLE;
-       }
+       } else
+               return;
 
        /*
         * We can't update a 64-bit BAR atomically, so when possible,