x86/mce/severity: Fix warning about indented braces
authorAravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Tue, 31 Mar 2015 15:04:41 +0000 (10:04 -0500)
committerIngo Molnar <mingo@kernel.org>
Fri, 3 Apr 2015 13:20:38 +0000 (15:20 +0200)
Dan reported compiler warnings about missing curly braces in
mce_severity_amd(). Reindent the catch-all "return MCE_AR_SEVERITY"
correctly to single tab.

While at it, chain ctx == IN_KERNEL check with mcgstatus check to make
it cleaner, as suggested by Boris.

No functional changes are introduced by this patch.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1427814281-18192-1-git-send-email-Aravind.Gopalakrishnan@amd.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/mcheck/mce-severity.c

index 155c9261d3efa39d6d1f677e09522e0b5bb2d332..9c682c222071db1960ba848c24c76567306d0542 100644 (file)
@@ -208,12 +208,11 @@ static int mce_severity_amd(struct mce *m, int tolerant, char **msg, bool is_exc
                 */
                if (mce_flags.overflow_recov) {
                        /* software can try to contain */
-                       if (!(m->mcgstatus & MCG_STATUS_RIPV))
-                               if (ctx == IN_KERNEL)
-                                       return MCE_PANIC_SEVERITY;
+                       if (!(m->mcgstatus & MCG_STATUS_RIPV) && (ctx == IN_KERNEL))
+                               return MCE_PANIC_SEVERITY;
 
-                               /* kill current process */
-                               return MCE_AR_SEVERITY;
+                       /* kill current process */
+                       return MCE_AR_SEVERITY;
                } else {
                        /* at least one error was not logged */
                        if (m->status & MCI_STATUS_OVER)